Warn users about performance issues with DateTime objects in setParameter() #8114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Apr 18, 2020
maks-rafalko
commented
Apr 18, 2020
|
Thanks, @greg0ire, applied |
greg0ire
approved these changes
Apr 18, 2020
SenseException
approved these changes
Apr 25, 2020
|
Thank you @greg0ire and @SenseException |
|
Thank you for this docs-addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full explanation of performance impact is explained in this bug report: #8113
Here is an attempt to warn developers about this potential issue, and to show how the third parameter can be used to avoid performance issue with DateTime* instances