Add pki-server cert-request #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pki-server cert-request has been added to simplify creating CSRs for system certs so it's no longer necessary to specify the NSS database path, password file, CSR path, and also to fix the file ownership. The cert_folder(), cert_file(), and csr_file() in PKIInstance have been moved into PKIServer so they can be reused. The cert_folder() has been renamed to certs_dir() for consistency. The PKIServer.create() and instance_layout.py have been updated to create the certs folder so it's guaranteed to exist. The RemoveCertCSRfromConfig upgrade script has been updated to use the new methods in PKIServer. The tests for installing CA with existing NSS database and existing HSM have been updated to use the new command.
|
Kudos, SonarCloud Quality Gate passed! |
|
@fmarco76 Thanks! I cleaned up the help messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pki-server cert-requesthas been added to simplify creating CSRs for system certs so it's no longer necessary to specify the NSS database path, password file, CSR path, and also to fix the file ownership.The
cert_folder(),cert_file(), andcsr_file()inPKIInstancehave been moved intoPKIServerso they can be reused. Thecert_folder()has been renamed tocerts_dir()for consistency.The
PKIServer.create()andinstance_layout.pyhave been updated to create thecertsfolder so it's guaranteed to exist.The
RemoveCertCSRfromConfigupgrade script has been updated to use the new methods inPKIServer.The tests for installing CA with existing NSS database and existing HSM have been updated to use the new command.
https://github.com/dogtagpki/pki/wiki/PKI-Server-Certificate-CLI
https://github.com/edewata/pki/blob/cli/docs/changes/v11.5.0/Tools-Changes.adoc