Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pki-server cert-fix #4937

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix pki-server cert-fix #4937

merged 2 commits into from
Jan 27, 2025

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jan 24, 2025

The pki-server cert-fix has been updated to skip ACME and EST subsystems since they don't have CS.cfg and are not needed to renew expired system certificates.

The --cert and --extra-cert options have also been updated to accept multiple values which are required by ipa-cert-fix.

A new --dm-password option has been added for specifying the Directory Manager password to simplify testing.

A new test has been added to install IPA with short-lived system certs then renew the certs using ipa-cert-fix which internally calls pki-server cert-fix.

See also:

Resolves: #4873

The pki-server cert-fix has been updated to skip ACME and EST
subsystems since they don't have CS.cfg and are not needed to
renew expired system certificates.

The --cert and --extra-cert options have also been updated to
accept multiple values which are required by ipa-cert-fix.

A new --dm-password option has been added for specifying the
Directory Manager password to simplify testing.

See also:

* https://github.com/dogtagpki/pki/blob/master/docs/admin/Offline_System_Certificate_Renewal.md
* https://github.com/dogtagpki/freeipa/wiki/Renewing-System-Certificates

Resolves: dogtagpki#4873
A new test has been added to install IPA with short-lived system
certs then renew the certs using ipa-cert-fix which internally
calls pki-server cert-fix.
@edewata edewata requested a review from fmarco76 January 24, 2025 20:32
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jan 27, 2025

@fmarco76 Thanks!

@edewata edewata merged commit c4a889b into dogtagpki:master Jan 27, 2025
166 of 172 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipa-cert-fix is failing with hsm using @pki/master copr repo
2 participants