Fix pki-server subsystem-cert-find #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PKISubsystem.get_cert_infos() has been updated to return a list instead of a generator object such that the number of entries can be counted using len(). The pki-server subsystem-cert-find/show commands have been deprecated since some of the certs returned by these commands are shared with other subsystems (e.g. sslserver, subsystem) which could cause some confusions. It's recommended to use pki-server cert-find/show instead. The test for basic OCSP installation has been updated to check the above commands.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PKISubsystem.get_cert_infos()has been updated to return a list instead of a generator object such that the number of entries can be counted usinglen().The
pki-server subsystem-cert-find/showcommands have been deprecated since some of the certs returned by these commands are shared with other subsystems (e.g.sslserver,subsystem) which could cause some confusions. It's recommended to usepki-server cert-find/showinstead.The test for basic OCSP installation has been updated to check the above commands.
https://github.com/edewata/pki/blob/cli/docs/changes/v11.6.0/Tools-Changes.adoc#deprecate-pki-server-subsystem-cert-findshow