Added ability to override VK_LOADER_LAYERS_DISABLE env var. #4588
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
requested changes
Jan 6, 2025
| #ifdef _WIN32 | ||
| ::SetEnvironmentVariableA(name, value); | ||
| #else | ||
| std::setenv(name, value); |
There was a problem hiding this comment.
This doesn't exist in the std namespace and has an extra parameter.
I'd be fine with printing a warning and not supporting this in native builds at all for the time being; apps using dxvk-native shouldn't be messing around with the Vulkan environment in the first place and we can still add it later if it does turn out to be needed.
Otherwise, we'd need to explicitly include posix headers here and also make sure it behaves the same as the Windows path (mostly relevant for handling the value == nullptr case, but also unicode considerations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing against an old Unity app on Windows, I discovered someone was setting VK_LOADER_LAYERS_DISABLE=
implicitwhich was preventing me from using RenderDoc to compare DX11 vs Vulkan output. Since dxvk is right in the middle of all of this, it provides an opportune place to fix that.