GameINI: fix Summoner: Goddess Reborn sound system crash during transitions
#13250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dolphin-emu-bot rebuild |
|
For anyone looking at this in the future. The issue is both a game bug that can happen on console, but happens much more often in Dolphin due to timings not being the same as console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summoner: Goddess Reborn will reinitialize the sound system buffers during transitions while sounds are still being played. There are still pointers in the sound list to sounds in those buffers when the buffers get cleared, so the game crashes with a null pointer dereference if an Audio Interface DMA interrupt is triggered while in that state.
This patch will clean up the pending sound list during sound system reinitialization before continuing to the sound system initialization call previously at 0x8017E338 (On GS2E78).
I would need to work with other people to patch the other regions of the game. If they need patching that is.