Skip to content

Commit

Permalink
feat(*): Upgrade to Angular 8 (#139)
Browse files Browse the repository at this point in the history
- Updgrade to Angular 8
- Update docs

BREAKING CHANGE: The upgrade to Angular 8 breaks compatibility with Angular 7 (and previous versions).
  • Loading branch information
dominique-mueller authored Oct 19, 2019
1 parent 06be2f6 commit b355287
Show file tree
Hide file tree
Showing 13 changed files with 8,813 additions and 7,099 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ import { ViewChild } from "@angular/core";
// ...
})
export class SomeComponent {
@ViewChild("customNotification") customNotificationTmpl;
@ViewChild("customNotification", {static: true}) customNotificationTmpl;

constructor(private notifierService: NotifierService) {}

Expand Down
10 changes: 5 additions & 5 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"newProjectRoot": "projects",
"projects": {
"angular-notifier": {
"projectType": "library",
"root": "projects/angular-notifier",
"sourceRoot": "projects/angular-notifier/src",
"projectType": "library",
"architect": {
"build": {
"builder": "@angular-devkit/build-ng-packagr:build",
Expand All @@ -24,9 +24,9 @@
}
},
"angular-notifier-demo": {
"projectType": "application",
"root": "projects/angular-notifier-demo/",
"sourceRoot": "projects/angular-notifier-demo/src",
"projectType": "application",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
Expand All @@ -36,15 +36,15 @@
"main": "projects/angular-notifier-demo/src/main.ts",
"polyfills": "projects/angular-notifier-demo/src/polyfills.ts",
"tsConfig": "projects/angular-notifier-demo/tsconfig.app.json",
"aot": false,
"assets": [
"projects/angular-notifier-demo/src/favicon.ico",
"projects/angular-notifier-demo/src/assets"
],
"styles": [
"projects/angular-notifier-demo/src/styles.scss"
],
"scripts": [],
"es5BrowserSupport": true
"scripts": []
},
"configurations": {
"production": {
Expand All @@ -60,7 +60,7 @@
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"extractLicenses": false,
"vendorChunk": false,
"buildOptimizer": true
}
Expand Down
Loading

0 comments on commit b355287

Please sign in to comment.