Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve use handling #111

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Improve use handling #111

merged 3 commits into from
Feb 23, 2024

Conversation

bsweeney
Copy link
Member

  • ensures nested groups are rendered
  • merges styles from use element with referenced element
  • fixes order of end render calls

@bsweeney
Improve use handling
a6c6595 
- ensures nested groups are rendered
- merges styles from use element with referenced element
- fixes order of end render calls
@bsweeney bsweeney added this to the 0.5.2 milestone Dec 11, 2023
@bsweeney bsweeney linked an issue Jan 10, 2024 that may be closed by this pull request
<use xlink:href="#ID"> problem #58
Closed
@bsweeney
Add method to apply element viewBox
441f4bc
@bsweeney
Improve symbol element parsing
52aaecc 
This change adds a separate Symbol tag class since the element should be treated slightly different from a Group, namely in that a vewBox can be applied. Additionally, a Symbol is like a def in that it should not be rendered until referenced by a Use element.

fixes #58
@bsweeney bsweeney merged commit 964d9a9 into master Feb 23, 2024
12 of 13 checks passed
@bsweeney bsweeney deleted the use-improvements branch February 23, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

<use xlink:href="#ID"> problem
1 participant
@bsweeney