Dotnet Watch: decouple browser launch and refresh #28885
Conversation
ghost
added
the
area-commandlinetools
zbecknell
changed the title
mkArtakMSFT
added
community-contribution
| context.ProcessSpec.EnvironmentVariables["DOTNET_STARTUP_HOOKS"] = pathToMiddleware; | ||
| context.ProcessSpec.EnvironmentVariables["ASPNETCORE_HOSTINGSTARTUPASSEMBLIES"] = "Microsoft.AspNetCore.Watch.BrowserRefresh"; | ||
| } | ||
| var pathToMiddleware = Path.Combine(AppContext.BaseDirectory, "middleware", "Microsoft.AspNetCore.Watch.BrowserRefresh.dll"); |
There was a problem hiding this comment.
Thanks @zbecknell for the PR. The worrying part of this change is that it will by default inject an ASP.NET Core middleware in every app that's launched by dotnet watch. If we were to consider a change, we need a better signal to indicate that you want the refresh but not the browser launching. The env variable isn't well advertised so I wouldn't consider that as a reasonable option.
|
What nuget package and release version is this in? I'm not getting browser refresh with |
|
Hi @rcdailey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Summary of the changes
dotnet watch runlaunchBrowser: falseinlaunchSettings.jsonand still allows automatic browser refreshing usingAddresses #25317