Added clarification for match expression multiline case #40762
Conversation
Discussed and approved in fsharp/fslang-design#650
Lanayx
requested review from
BillWagner,
KathleenDollard and
a team
as code owners
dotnet-policy-service
bot
added
the
community-contribution
| @@ -1092,16 +1092,24 @@ match l with | |||
| | [] -> failwith "Couldn't find David" | |||
| ``` | |||
|
|
|||
| If the expression on the right of the pattern matching arrow is too large, move it to the following line, indented one step from the `match`/`|`. | |||
| If one of the expressions on the right of the pattern matching arrow is too large, move it to the following line, indented one step from the `match`/`|`. Move all the other expressions to the next line as well for consistency. | |||
There was a problem hiding this comment.
I don't interpret Don's last comment in the suggestion as setting this as the default, but rather an option.
I think the wording should reflect that (or the suggestion discussion continued about the default-ness of this)
There was a problem hiding this comment.
@dsyme set the label style-guide-decided, so I regard it as a marker that style guide is decided (final decision). As I understand, Don was not sure about tooling changes needed to support this style, but it should not affect the style and the recommendation itself.
There was a problem hiding this comment.
The label is fine.
What I do not see confirmed is that "defaultness" of this, I interpret the context of the suggestion that this should still remain a possible option only.
There was a problem hiding this comment.
Ok, looks like it can't be resolved without Don
There was a problem hiding this comment.
I agree with @T-Gro , here is what Don said
I agree with @isaacabraham that at option (4) listed above should be an option.
(emphasis mine)
cc: @vzarytovskii
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Closing PR as it appeared that assumption of approved style was wrong |
Discussed and approved in fsharp/fslang-design#650
Internal previews