-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed tracing in networking #44063
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content. Lets make the changes to the core telemetry example so you don't need to document how to modify it.
Co-authored-by: Sam Spencer <[email protected]>
Co-authored-by: Sam Spencer <[email protected]>
…/docs into af/network-tracing-2
@gewarren would you mind doing a language review on this? (Though I think it's mostly ok, so it's optional.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait to review the rest until you've run Acrolinx (see one of the comments I left).
@@ -17,16 +17,20 @@ They are also [multi-dimensional](../../../core/diagnostics/metrics-instrumentat | |||
> [!TIP] | |||
> For a comprehensive list of all built-in instruments together with their attributes, see [System.Net metrics](../../../core/diagnostics/built-in-metrics-system-net.md). | |||
|
|||
## Collect System.Net metrics | |||
## Collecting System.Net metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been trained not to use -ing words in headings and titles - see for example https://review.learn.microsoft.com/help/platform/metadata-required-articles?branch=main#title.
|
||
There are two parts to using metrics in a .NET app: | ||
In order to take advangage of the built-in metrics instrumentation, a .NET app needs to be configured to collect these metrics. This typically means transforming them for external storage and analysis, e.g., to monitoring systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you edit these files in VS Code? If so, it would be good to run Acrolinx on them to find a lot of the stuff that I would otherwise find. See https://review.learn.microsoft.com/en-us/help/platform/acrolinx-vscode-setup?branch=main#install-acrolinx-in-visual-studio-code.
|
||
There are two parts to using metrics in a .NET app: | ||
In order to take advangage of the built-in metrics instrumentation, a .NET app needs to be configured to collect these metrics. This typically means transforming them for external storage and analysis, e.g., to monitoring systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to take advangage of the built-in metrics instrumentation, a .NET app needs to be configured to collect these metrics. This typically means transforming them for external storage and analysis, e.g., to monitoring systems. | |
To take advantage of the built-in metrics instrumentation, a .NET app needs to be configured to collect these metrics. This typically means transforming them for external storage and analysis, for example, for monitoring systems. |
This is a major rework of #42830, extending the content, making the information more specific and IMO easier to follow. The biggest change is the in the collection paragraphs:
Metrics.md
: Added back thedotnet-monitor
example. Reintroduced a short paragraph on prometheus/grafana, since the referenced docs need some augmentation.Internal previews