Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Interlocked.{In|De}crement #9424

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Nov 1, 2023

Summary

Fix some ambiguous English. Was "the decremented value" the value that was decremented, or the value after it was decremented? A bit of thought indicates that it must be the latter (otherwise the API is useless), but why make the user do that thinking.

@Smaug123 Smaug123 requested a review from kouvel as a code owner November 1, 2023 17:18
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 1, 2023
Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Learn Build status updates of commit ce7ce73:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/Interlocked.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@kouvel
Copy link
Member

kouvel commented Nov 1, 2023

Actually it would probably be good to update all of the other overloads in the same change. @Smaug123 if you want to do that, that would be great, or I can do so later.

@Smaug123
Copy link
Contributor Author

Smaug123 commented Nov 1, 2023

Ah sorry, I didn't think to search for other overloads 🤦 coming up.

Copy link

Learn Build status updates of commit be95a41:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Threading/Interlocked.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@kouvel
Copy link
Member

kouvel commented Nov 2, 2023

Much appreciated, thanks!

@kouvel kouvel merged commit a4281bf into dotnet:main Nov 2, 2023
@Smaug123 Smaug123 deleted the increment-decrement branch November 17, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants