Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AddDays exception #9447

Closed
wants to merge 1 commit into from
Closed

Document AddDays exception #9447

wants to merge 1 commit into from

Conversation

ploeh
Copy link
Contributor

@ploeh ploeh commented Nov 11, 2023

@ploeh ploeh requested a review from a team as a code owner November 11, 2023 21:46
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 11, 2023
Copy link

Learn Build status updates of commit 2a7b078:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/DateOnly.xml ⚠️Warning View Details

xml/System/DateOnly.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_CrefTypePrefixMissing] Invalid cref format (ArgumentOutOfRangeException) detected in C:\LocalRun\W\ahay-s\xml\System\DateOnly.xml
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'MaxValue'.
  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'ArgumentOutOfRangeException'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

<param name="value">The number of days to add. To subtract days, specify a negative number.</param>
<summary>Adds the specified number of days to the value of this instance.</summary>
<returns>An instance whose value is the sum of the date represented by this instance and the number of days represented by value.</returns>
<exception cref="ArgumentOutOfRangeException">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do it as it is done in

<exception cref="T:System.ArgumentOutOfRangeException">
.

Also, please revert any white spaces changes in the file you are editing. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was just using the GitHub web editor for this, so it must have been making all the whitespace changes...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I'll wait for your update and then we can proceed. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to send another pull request in order to avoid Git-history trashing.

@tarekgh tarekgh self-assigned this Nov 12, 2023
@ploeh
Copy link
Contributor Author

ploeh commented Nov 14, 2023

Superseded by #9453.

@ploeh ploeh closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants