-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document AddDays exception #9447
Conversation
Learn Build status updates of commit 2a7b078:
|
File | Status | Preview URL | Details |
---|---|---|---|
xml/System/DateOnly.xml | View | Details |
xml/System/DateOnly.xml
- Line 0, Column 0: [Warning: ECMA2Yaml_CrefTypePrefixMissing]
Invalid cref format (ArgumentOutOfRangeException) detected in C:\LocalRun\W\ahay-s\xml\System\DateOnly.xml
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'MaxValue'.
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'ArgumentOutOfRangeException'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
<param name="value">The number of days to add. To subtract days, specify a negative number.</param> | ||
<summary>Adds the specified number of days to the value of this instance.</summary> | ||
<returns>An instance whose value is the sum of the date represented by this instance and the number of days represented by value.</returns> | ||
<exception cref="ArgumentOutOfRangeException"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do it as it is done in
dotnet-api-docs/xml/System/DateTime.xml
Line 977 in 173aa81
<exception cref="T:System.ArgumentOutOfRangeException"> |
Also, please revert any white spaces changes in the file you are editing. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was just using the GitHub web editor for this, so it must have been making all the whitespace changes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. I'll wait for your update and then we can proceed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to send another pull request in order to avoid Git-history trashing.
Superseded by #9453. |
As requested by @tarekgh: dotnet/runtime#94635 (comment)