Took some fixes from FSharp.TypeProvider.SDK to TestTP. #18252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took some separate changes from
fsprojects/FSharp.TypeProvider.SDK
to TestTP.The goal would be to get these files as close to each other as possible.
After that, you can discuss whether TPs should be maintained in the F# compiler repo or not, if you like.
This file is only changing tests, so no production changes should appear.
Thus no readme changes or release notes.
Remarks:
dotnet/fsharp
test projects in three separate times. Only TestTP seems to be included in the solution, the others are some kind of other integration tests. They seem to be living a little bit of their own life; all are a bit different. Considering that ProvidedTypes.fs is like 800kB size, it could make sense to have the file only once, and then include the file as link to other places.