[Cluster Membership] Improve disaster recovery #9296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Construct expander graph for monitoring to improve coverage on larger clusters * More aggressive default IAmAlive updates 5 min period * 2 missed updates (10 min) -> 30s * 3 (90 sec) * MembershipTableManager: allow membership updates with equal version and newer IAmAlive values * Increase NumProbedSilos from 3 to 10 * Silos proactively monitor all stale silos * Account for some local clock misconfigurations in ValidateInitialConnectivity by snapping to latest IAmAliveTime * Include intermediary silo vote in table after failed indirect probe
ReubenBond
commented
Jan 27, 2025
ReubenBond
commented
Jan 27, 2025
| // Include the indirect probe silo's vote as well, if it exists. | ||
| if (indirectProbingSilo is not null) | ||
| { | ||
| entry.AddOrUpdateSuspector(indirectProbingSilo, now, clusterMembershipOptions.NumVotesForDeathDeclaration); |
There was a problem hiding this comment.
Include the intermediary silo's address in the suspectors list, counting it as a unique vote.
ReubenBond
commented
Jan 27, 2025
ReubenBond
commented
Jan 27, 2025
| @@ -11,6 +11,7 @@ | |||
| using System.Text; | |||
| using System.Text.Json; | |||
| using System.Text.Json.Serialization; | |||
| using Orleans.Serialization.Configuration; | |||
There was a problem hiding this comment.
This is likely superfluous
benjaminpetit
approved these changes
Jan 28, 2025
ReubenBond
commented
Jan 28, 2025
|
I want to split this into multiple PRs, one per logical change... I'll close this once I have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow