Add unit tests for DesignerFrame #12712
Open
+113
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12712 +/- ##
====================================================
- Coverage 75.75455% 50.02710% -25.72745%
====================================================
Files 3159 1979 -1180
Lines 635942 284168 -351774
Branches 46987 41745 -5242
====================================================
- Hits 481755 142161 -339594
+ Misses 150726 139305 -11421
+ Partials 3461 2702 -759
Flags with carried forward coverage won't be shown. Click here to find out more. |
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignerFrameTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignerFrameTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignerFrameTests.cs
Show resolved
Hide resolved
ricardobossan
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
| FieldInfo? designerField = typeof(DesignerFrame).GetField("_designer", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| object designer = designerField?.GetValue(designerFrame) ?? throw new InvalidOperationException("Field '_designer' not found in DesignerFrame."); | ||
|
|
||
| designer.Should().Be(control); |
There was a problem hiding this comment.
Hm, this test looks strange, designer can't be the same thing as the control.
Is t possible to replace reflection with internal methods that access the designer within the frame?
Tanya-Solyanik
added
the
📭 waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow