Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create arch neutral packages when building inside the VMR #10405

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Create arch neutral packages when building inside the VMR #10405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4942ee7
Create arch neutral packages when building inside the VMR
ViktorHofer Feb 4, 2025
8fd115c
Update packaging rules for platform neutral packages
ViktorHofer Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packaging/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@
Set $(IsPackable) = true, except when
$(CreateArchNeutralPackage) == true && $(Platform) != x86
The idea here is that for arch-neutral packages, only the x86 build phase will generate the nuget package
The platform/RID specific packages will be generated in their respective $(Platform) specific build phases
The platform/RID specific packages will be generated in their respective $(Platform) specific build phases.
Platform neutral packages should always get generated when building the product (DotNetBuild=true).
-->
<IsPackable>true</IsPackable>
<IsPackable Condition="('$(Platform)'!='AnyCPU' and '$(Platform)'!='Win32' and '$(Platform)'!='x86') and '$(CreateArchNeutralPackage)'=='true'">false</IsPackable>
<IsPackable Condition="('$(Platform)'!='AnyCPU' and '$(Platform)'!='Win32' and '$(Platform)'!='x86') and '$(CreateArchNeutralPackage)'=='true' and '$(DotNetBuild)' != 'true'">false</IsPackable>
</PropertyGroup>

<PropertyGroup>
Expand Down