Configurable default query terms operator (AND or OR) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sily, especially to introduce new or modified query operators.
…ery string. Still defaults to :and which is the legacy aai behaviour. The other operator is :or.
…rator for query terms
|
Hi Pascal. Some cool stuff in here, I especially like the Query class. I won't be adding it to the next release, but I will be looking at this more thoroughly for an upcoming release. Thanks for your contribution. D. |
|
You're welcome. Take a look at the relevant factor, because I really think this is a bug (relevant factor being reversed) Best Regards, |
|
This commit? de0a0b2 |
|
I put that in its own branch, this commit: phurni@369f751 Note thought that I didn't pushed the patch upstream here, I'll do that in the following days. |
|
Ooh, that is a doozy of a bug! Definitely worthy of a new release ASAP. I'll get on that tomorrow. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of
SearchIndexand added new feature to let the user chose the default operator between query terms to AND (legacy) or OR (new).Explicit AND can also be expressed when the default operator is OR (best of both worlds).
Upgrading to this new version will not break existing code (tests are green).