Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github dependency #145

Closed
1 of 3 tasks
patrick-stirnemann opened this issue May 2, 2018 · 3 comments
Closed
1 of 3 tasks

Github dependency #145

patrick-stirnemann opened this issue May 2, 2018 · 3 comments

Comments

@patrick-stirnemann
Copy link

I'm submitting a ...:

  • bug report
  • feature request
  • documentation issue

Bug report

Current behavior:
"npm install" fails in our build pipeline because it cannot get the plist package due to the external reference to github.

Expected behavior:
Every reference in package.json should be done with a version number.

Other information:
package.json (version 5.0.2)
line 34: "plist": "xiangpingmeng/plist.js"

@dpa99c
Copy link
Owner

dpa99c commented May 2, 2018

The reason that a Github fork of plist.js is referenced in the package.json is because the versions published to NPM contain an unresolved bug which causes issues in this plugin.

So until such time that a version of plist is published to npm which contains a fix, this plugin's package.json will continue to reference the Github repo which contains the bugfixed version.

@dpa99c dpa99c closed this as completed May 2, 2018
@huerlisi
Copy link

huerlisi commented May 7, 2018

According to TooTallNate/plist.js#67 (comment) the referenced bug might well be fixed in the currently released version of plist.

Who could validate this?

We're expecting build failures with the current version of cordova-custom-config as we're behind a corporate proxy that prevents direct dependencies on github (we're using a local npm mirror).

Thanks for this package and all the awesome work here!

@devsheder
Copy link

Hi @dpa99c ,
I have the same problem as above : my client is behind a corporate proxy and we can't use the lastest versions of your plugin.
Were you able to contact xiangpingmeng ? Do we have to fork his project ?

Thx a lot for your work,
See you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants