fix empty <key /> lead index out of bounds issue #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@xiangpingmeng I believe this PR can be closed as a fix for this issue has landed with #84 |
|
@ZauberNerd thanks a lot for following up, closing the loop on these related issues. Your diligence is greatly appreciated! 🥇 |
3 tasks
|
@xiangpingmeng could you check if @ZauberNerd is right with his assumption that #84 also fixes this? I'm asking in the context of dpa99c/cordova-custom-config#145 (comment) Thanks! |
|
i think this PR can be closed, because the issue is already fixed in master and it hasnt been updated in a long time (and have conflicts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent 'index of bounds' issues from empty node.
see: #66