Add custom encoding to dump/dumps. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figuring out how to handle the interaction between this and encoding floats was too awkward, so instead we'll just rely on a custom encoder class for customization.
Two big changes: 1. We no longer needed a full-blown custom arg parser, so this change deletes everything in arg_parser.py and adds a small custom arg parser that just has a slightly customized error message printer. 2. It gets rid of the FakeHost code and changes how the tool_test tests are run to either run them as real integration tests or as in-process tests with mocked-out stdin/stderr/stdout. The latter is more fragile than using a fake host, but it allows us to delete test code.
Now they will calculate how many single and double quotes there are in the string, and use the encoding that minimizes the number of quotes that need to be escaped. This appears to match the string normalization logic that ruff uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57 for the motivation for these changes.