Bug rfc1918 correction #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge origin
Feature flexible localpublic ip
davehorton
reviewed
Nov 29, 2023
davehorton
reviewed
Nov 29, 2023
|
@tinpotnick I'd prefer to merge this PR without the change to the Dockerfile, as I am not sure that will work in 100% of the cases. Could you remove that piece for now, or to a separate PR? |
|
Removed non-related items |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the RFC 1918 address ranges.
I haven't fixed anything I set out to, as when setting the external IP this becomes the address to check and doesn't use these addresses for external IP - which is where the --local-net flag comes in.
I have opened this PR for correctness.