[Backport] 8319053: Segment dump files remain after parallel heap dump on Windows #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p on Windows Summary: Segment file is closed from DumpWriter dtor. On Unix systems remove can delete an opened file, on Windows it fails with "access denied". The fix destroys DumpWriter objects for segment files after all data are dumped Test Plan: HeapDumpParallelTest.java Reviewed-by: D-D-H, yuleil Issue: dragonwell-project#714
D-D-H
approved these changes
Nov 6, 2023
yuleil
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Segment file is closed from DumpWriter dtor. On Unix systems remove can delete an opened file, on Windows it fails with "access denied". The fix destroys DumpWriter objects for segment files after all data are dumped
Test Plan: HeapDumpParallelTest.java
Reviewed-by: D-D-H, yuleil
Issue: #714