[Backport] JDK-8187305, JDK-8257731, JDK-8265783, JDK-8258073 #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 8187305: Add logging for shared library loads/unloads Test Plan: ci jtreg Reviewed-by: JoshuaZhuwj Issue: TBD
Summary: 8257731: Remove excessive include of stubRoutines.hpp Test Plan: ci jtreg Reviewed-by: JoshuaZhuwj Issue: TBD
…mbly intrinsics Summary: [Backport] 8265783: Create a separate library for x86 Intel SVML assembly intrinsics Test Plan: ci jtreg Reviewed-by: JoshuaZhuwj Issue: dragonwell-project#616
Summary: 8258073: x86_32 build broken after JDK-8257731 Test Plan: ci jtreg Reviewed-by: JoshuaZhuwj Issue: TBD
|
@JoshuaZhuwj Please help review it. |
|
Great! Zhonghui, thanks a lot for your efforts. |
JoshuaZhuwj
approved these changes
Nov 27, 2023
| @@ -3569,19 +3569,25 @@ JVM_ENTRY_NO_ENV(void*, JVM_LoadLibrary(const char* name, jboolean throwExceptio | |||
| return load_result; | |||
There was a problem hiding this comment.
Please add
log_info(library)("Failed to load library %s", name);
| uint CallLeafVectorNode::cmp( const Node &n ) const { | ||
| CallLeafVectorNode &call = (CallLeafVectorNode&)n; | ||
| return CallLeafNode::cmp(call) && _num_bits == call._num_bits; | ||
| } |
There was a problem hiding this comment.
It would be better place these two functions CallLeafVectorNode::cmp() and CallLeafVectorNode::size_of() after CallLeafNode::dump_spec() instead of CallRuntimeNode::dump_spec()
JoshuaZhuwj
merged commit f27b3db
into
dragonwell-project:VectorAPI_dev
33 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: [Backport] JDK-8187305, JDK-8257731, JDK-8265783, JDK-8258073