fix test + docs

NAMESPACE

@@ -46,6 +46,7 @@ importFrom(htmltools,doRenderTags)
 importFrom(htmltools,htmlDependency)
 importFrom(htmltools,singleton)
 importFrom(htmltools,tagAppendAttributes)
+importFrom(htmltools,tagAppendChild)
 importFrom(htmltools,tagList)
 importFrom(htmltools,tags)
 importFrom(htmltools,validateCssUnit)

R/import-file.R

@@ -14,8 +14,9 @@
 #' @name import-file
 #'
 #' @importFrom shiny NS fileInput tableOutput actionButton icon
-#' @importFrom htmltools tags tagAppendAttributes css
+#' @importFrom htmltools tags tagAppendAttributes css tagAppendChild
 #' @importFrom shinyWidgets pickerInput numericInputIcon textInputIcon dropMenu
+#' @importFrom phosphoricons ph
 #'
 #' @example examples/from-file.R
 import_file_ui <- function(id,
@@ -69,14 +70,14 @@ import_file_ui <- function(id,
             min = 0,
             icon = list("n =")
           ),
-          htmltools::tagAppendChild(
+          tagAppendChild(
             textInputIcon(
               inputId = ns("na_label"),
               label = i18n("Missing values character(s):"),
               value = ",NA",
               icon = list("NA")
             ),
-            shiny::helpText("if several use a ',' to separate them")
+            shiny::helpText(ph("info"), "if several use a comma (',') to separate them")
           ),
           textInputIcon(
             inputId = ns("dec"),

R/utils.R

@@ -147,5 +147,7 @@ header_with_classes <- function(data) {
 
 
 split_char <- function(x, split = ",") {
+  if (is.null(x))
+    return(NULL)
   unlist(strsplit(x, split = split))
 }

tests/testthat/test-import-file.R

@@ -14,7 +14,8 @@ test_that("import_file_server works", {
       skip_rows = 0,
       confirm = 0,
       dec = ".",
-      encoding = "UTF-8"
+      encoding = "UTF-8",
+      na_label = ",NA"
     )
     expect_is(imported_rv$data, "data.frame")
     expect_is(session$getReturned()$data(), "data.frame")