Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for typing special forms #115

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix error for typing special forms #115

merged 2 commits into from
Apr 11, 2024

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Apr 11, 2024

Fixes runtime error when adding models that have fields annotated with certain typing special forms like Any and TypeVar instances.

Closes #114.

Copy link
Contributor

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.4%. Comparing base (e712754) to head (82b373b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #115     +/-   ##
=======================================
- Coverage   98.5%   96.4%   -2.1%     
=======================================
  Files         19      19             
  Lines        816     821      +5     
=======================================
- Hits         804     792     -12     
- Misses        12      29     +17     
Files Coverage Δ
erdantic/core.py 97.3% <83.3%> (-0.8%) ⬇️

... and 8 files with indirect coverage changes

@jayqi jayqi merged commit c687b03 into main Apr 11, 2024
17 checks passed
@jayqi jayqi deleted the 114-typevar branch April 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: erdantic v1 fails with Generics and TypeVar
1 participant