Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timm package #8

Closed
wants to merge 3 commits into from
Closed

timm package #8

wants to merge 3 commits into from

Conversation

arnaudlenain
Copy link

No description provided.

@ejm714 ejm714 mentioned this pull request Jan 17, 2025
Comment on lines +28 to +30
#speechbrain = "==1.0.1"
#openai-whisper = "==20240930"
#opensmile = "==2.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting these out would remove them from the runtime environment, which is shared by all competitors. It's not allowed to remove or change the versions of any packages that are already installed

@@ -1,3 +1,113 @@
#################################################################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs to add packages should only modify the pixi.lock and pixi.toml files. See for example https://github.com/drivendataorg/literacy-screening-runtime/pull/6/files

@ejm714
Copy link
Contributor

ejm714 commented Jan 17, 2025

Hi @arnaudlenain, unfortunately I can't approve this PR because it has conflicts with the main branch, adds a bunch of extra files, and removes packages that should exist in the runtime environment. I see that you're wanting the timm package so I've opened #9 with the correct way to add a new package. Once that gets merged, timm will be available in the runtime environment for you

@ejm714 ejm714 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants