fix Bound filter's empty argument checking for 'lower' and 'upper' #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I found a quite obvious bug when I use the
Bound
filter.The minimum code to reproduce the bug is as below:
this will cause the following exception:
But when I changed
lower=0
intolower=1
, everything just went well:output:
Obviously, the root of the problem lies in line 217, which is to check whether argument
lower
andupper
are both omitted:However, this checking unexpectedly blocked the number
0
, besidesNone
.Changing this line into the line below should fix the bug: