-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with 'Test-DscParameterState' #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
a discussion (no related file):
Please create an issue to track that this should be changed when Test-DscParameterState
in DscResource.Common is updated to support these resources, or these resource is updated to support Test-DscParameterState
in DscResource.Common. Not sure where the incompatibility are. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
Thanks, I have created #37 for tracking the removal of Test-DscParameterState2. |
@raandree Do you have permission to merge this yourself? |
@johlju, no, I am not a maintainer of any resource yet. |
I usually leave PR so the maintainers can merge them them-self. I didn't remember if you were a maintainer or not. You are more than welcome to be if you like! 😃 |
This is merged now. |
Pull Request (PR) description
'Test-DscParameterState' is defined in 'JeaDsc.Common' and 'DscResource.Common' which leads to a conflict. 'Test-DscParameterState' was renamed to 'Test-DscParameterState2'.
Pester version was changed from latest to 4.10.1.
Removed dependency to PSPKI module as it was not required.
This Pull Request (PR) fixes the following issues
Fixes #35
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)