Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 'Test-DscParameterState' #36

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Issue with 'Test-DscParameterState' #36

merged 3 commits into from
Jun 3, 2020

Conversation

raandree
Copy link

@raandree raandree commented May 29, 2020

Pull Request (PR) description

'Test-DscParameterState' is defined in 'JeaDsc.Common' and 'DscResource.Common' which leads to a conflict. 'Test-DscParameterState' was renamed to 'Test-DscParameterState2'.

Pester version was changed from latest to 4.10.1.

Removed dependency to PSPKI module as it was not required.

This Pull Request (PR) fixes the following issues

Fixes #35

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

a discussion (no related file):
Please create an issue to track that this should be changed when Test-DscParameterState in DscResource.Common is updated to support these resources, or these resource is updated to support Test-DscParameterState in DscResource.Common. Not sure where the incompatibility are. 🙂


Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 3, 2020
@raandree
Copy link
Author

raandree commented Jun 3, 2020

Thanks, I have created #37 for tracking the removal of Test-DscParameterState2.

@johlju
Copy link
Member

johlju commented Jun 3, 2020

@raandree Do you have permission to merge this yourself?

@raandree
Copy link
Author

raandree commented Jun 3, 2020

@johlju, no, I am not a maintainer of any resource yet.

@johlju johlju merged commit 1a0b322 into dsccommunity:master Jun 3, 2020
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jun 3, 2020
@johlju
Copy link
Member

johlju commented Jun 3, 2020

I usually leave PR so the maintainers can merge them them-self. I didn't remember if you were a maintainer or not. You are more than welcome to be if you like! 😃

@johlju
Copy link
Member

johlju commented Jun 3, 2020

This is merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The local Test-DscParameterState is conflicting with the one in DscResource.Common
2 participants