-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bar-styling): remove glamorous div from header bars #588
Conversation
Replaced styled components with style objects. Applied styles with css prop. re dsmjs#571
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 39 39
Lines 191 186 -5
=====================================
- Hits 191 186 -5
Continue to review full report at Codecov.
|
@@ -7,6 +7,6 @@ suite('dsmJS bar', () => { | |||
test('that dsmJS is shown', () => { | |||
const wrapper = shallow(<DsmJsBar />); | |||
|
|||
assert.equal(wrapper.dive().text(), 'dsmJS'); | |||
assert.equal(wrapper.shallow().text(), 'dsmJS'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the .shallow()
can just be removed here and in the other cases
assert.equal(wrapper.shallow().text(), 'dsmJS'); | |
assert.equal(wrapper.text(), 'dsmJS'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh okay! I'm not familiar with the testing platform 🙈 dive
was giving errors. Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the assertions should be able to be simplified by removing the second shallow call
Unnecessary |
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replaced styled components with style objects. Applied styles with css prop.
re #571