-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Optuna Sensor Manager #1106
base: main
Are you sure you want to change the base?
Conversation
d0d11c2
to
c6762be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 93.72% 93.66% -0.06%
==========================================
Files 214 215 +1
Lines 14004 14055 +51
Branches 1925 1934 +9
==========================================
+ Hits 13125 13165 +40
- Misses 627 633 +6
- Partials 252 257 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The warnings below were produced by the tests. Looks like it results in the last step being missed out. Looks like the original numbers check out correct as floating points, but the way optuna checks is by converting to strings and decimals, and guess then rounding error occurs. Could either do something similar and ensure to round high value up; or just adding on a small number would probably do (some small multiple of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well for me!
If it doesn't break anything it might be worth adding the action_from_value method to the RealNumberActionGenerator, as otherwise I think it only exists in the DwellActionGenerator. (this is also a problem for both of the scipy sensor managers so there might be a reason we didn't, I can't remember!)
Add a new sensor manager that utilises the
optuna
module to determine the best action available within a giventimeout
period.