Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chsql_native 0.0.2 #246

Merged
merged 5 commits into from
Jan 2, 2025
Merged

chsql_native 0.0.2 #246

merged 5 commits into from
Jan 2, 2025

Conversation

lmangani
Copy link
Contributor

@lmangani lmangani commented Jan 1, 2025

Changes in chsql_native 0.0.2

Implements a Native ClickHouse binary TCP Client for DuckDB as alternative to the existing HTTP based client macro available in chsql.

  • Includes vendored OpenSSL Rust crate to enable TLS

ducks-ezgif com-optimize

chsql_native is an extension for chsql adding ClickHouse native file reading capabilities
@lmangani lmangani marked this pull request as ready for review January 1, 2025 19:09
@lmangani lmangani marked this pull request as draft January 2, 2025 10:12
@lmangani
Copy link
Contributor Author

lmangani commented Jan 2, 2025

Note to team: the Rust extension builder doesn't offer OpenSSL dependencies so we had to include a vendored version, which is not ideal. Could the OpenSSL dependency be added to the Rust vcpgg builder as in the cpp template?

cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
  X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
  OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
  X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
  OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
  X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_DIR
  OPENSSL_DIR = /duckdb_build_dir/build/release/vcpkg_installed/x64-linux

@lmangani lmangani marked this pull request as ready for review January 2, 2025 10:46
@samansmink samansmink merged commit df5e465 into duckdb:main Jan 2, 2025
24 checks passed
@lmangani
Copy link
Contributor Author

lmangani commented Jan 2, 2025

Thanks @samansmink 👋

@samansmink
Copy link
Collaborator

you're very welcome, and happy new year! :)

On the openssl thing: for the C++ extension template, we do set the openssl env variables to point to the vcpkg installed openssl build.

For the rust extension builder, this does indeed sound like a good idea to have openssl properly configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants