Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_prompt 0.0.5 #255

Merged
merged 3 commits into from
Jan 11, 2025
Merged

open_prompt 0.0.5 #255

merged 3 commits into from
Jan 11, 2025

Conversation

lmangani
Copy link
Contributor

@lmangani lmangani commented Jan 7, 2025

Changes

  • Support ENV and DuckDB SECRETS for extension settings
  • Extended description for extension w/ instructions

Thanks to @aborruso for the assistance testing the changes

@lmangani lmangani changed the title open_prompt 0.0.5 WIP: open_prompt 0.0.5 Jan 7, 2025
@carlopi
Copy link
Collaborator

carlopi commented Jan 8, 2025

(failure connected to naming of rtools / mingw platform should be now solved via #258)

@lmangani
Copy link
Contributor Author

lmangani commented Jan 8, 2025

Thanks @carlopi we're running some more tests and I'll update the PR to recheck later today

@lmangani
Copy link
Contributor Author

lmangani commented Jan 8, 2025

side question @carlopi what's the ideal state for the .gitmodules (duckdb, ci-tools) in the extension repo when submitting a new version to the community repo and/or does it not matter for the actions? Shall they point to main or a specific release?

@carlopi
Copy link
Collaborator

carlopi commented Jan 8, 2025

side question @carlopi what's the ideal state for the .gitmodules (duckdb, ci-tools) in the extension repo when submitting a new version to the community repo and/or does it not matter for the actions? Shall they point to main or a specific release?

Brief version is:

  • extension-ci-tools should likely point to latest available main
  • duckdb version should point either to latest stable release (v1.1.3) or a somewhat recent main branch (to become v1.2.x), depending whether it does matter supporting v1.1.3 or main.

I would say given we are close to release it's advised to move to main, possibly leaving to CI to double check whether compatibility is working correctly.

I am going to add more context while solving #223, feel free to subscribe for updates there.

@lmangani lmangani marked this pull request as ready for review January 11, 2025 15:34
@lmangani lmangani changed the title WIP: open_prompt 0.0.5 open_prompt 0.0.5 Jan 11, 2025
@lmangani
Copy link
Contributor Author

This will be probably be the last update for 1.1.3 users requesting this feature - thanks & enjoy!

@carlopi carlopi merged commit 8dd5e62 into duckdb:main Jan 11, 2025
72 checks passed
@lmangani
Copy link
Contributor Author

Grazie @carlopi

@aborruso
Copy link

It works, thank you @carlopi and @lmangani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants