Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipfs #274

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Add zipfs #274

merged 6 commits into from
Jan 20, 2025

Conversation

isaacbrodsky
Copy link
Contributor

No description provided.

@carlopi
Copy link
Collaborator

carlopi commented Jan 19, 2025

It seems to be compatible with main (great), but not with v1.1.3.

I think either:

  • waiting for v1.2.0, and then merging
  • add some way to say "ref: -; ref_next: abcdef012345;", where - means skip this
  • fixing at the code level (unsure if worth)

@isaacbrodsky
Copy link
Contributor Author

It seems to be compatible with main (great), but not with v1.1.3.

I think either:

* waiting for v1.2.0, and then merging

* add some way to say "ref: -; ref_next: abcdef012345;", where `-` means skip this

* fixing at the code level (unsure if worth)

I initially developed it against v1.1.3, so I think that is just a mistaken edit when I was updating for main. I updated the ref once again, and I think it will turn green now...

@carlopi
Copy link
Collaborator

carlopi commented Jan 20, 2025

Thanks a lot!

@carlopi carlopi merged commit 88230be into duckdb:main Jan 20, 2025
68 checks passed
@isaacbrodsky isaacbrodsky deleted the zipfs branch January 20, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants