Skip to content

Commit

Permalink
autoload('parquet') since it's needed for scan_parquet
Browse files Browse the repository at this point in the history
  • Loading branch information
carlopi committed Nov 11, 2024
1 parent e02abad commit 4740aa1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/functions/delta_scan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "duckdb/common/types/data_chunk.hpp"
#include "duckdb/execution/expression_executor.hpp"
#include "duckdb/function/table_function.hpp"
#include "duckdb/main/extension_helper.hpp"
#include "duckdb/main/extension_util.hpp"
#include "duckdb/main/secret/secret_manager.hpp"
#include "duckdb/optimizer/filter_combiner.hpp"
Expand Down Expand Up @@ -937,9 +938,11 @@ bool DeltaMultiFileReader::ParseOption(const string &key, const Value &val, Mult
//}

TableFunctionSet DeltaFunctions::GetDeltaScanFunction(DatabaseInstance &instance) {
// Parquet extension needs to be loaded for this to make sense
AutoLoadExtension(instance, "parquet");

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Generated Tests (Linux)

‘AutoLoadExtension’ was not declared in this scope; did you mean ‘AutoloadException’?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Generated Tests (Linux)

‘AutoLoadExtension’ was not declared in this scope; did you mean ‘AutoloadException’?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Performance Regression Tests

‘AutoLoadExtension’ was not declared in this scope; did you mean ‘AutoloadException’?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Performance Regression Tests

‘AutoLoadExtension’ was not declared in this scope; did you mean ‘AutoloadException’?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Minio (local S3 test server) tests (Linux)

‘AutoLoadExtension’ was not declared in this scope; did you mean ‘AutoloadException’?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Minio (local S3 test server) tests (Linux)

‘AutoLoadExtension’ was not declared in this scope; did you mean ‘AutoloadException’?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

use of undeclared identifier 'AutoLoadExtension'; did you mean 'ExtensionHelper::AutoLoadExtension'?

Check failure on line 942 in src/functions/delta_scan.cpp

View workflow job for this annotation

GitHub Actions / Build extension binaries / MacOS (osx_arm64, arm64, arm64-osx)

use of undeclared identifier 'AutoLoadExtension'; did you mean 'ExtensionHelper::AutoLoadExtension'?

// The delta_scan function is constructed by grabbing the parquet scan from the Catalog, then injecting the
// DeltaMultiFileReader into it to create a Delta-based multi file read

auto &parquet_scan = ExtensionUtil::GetTableFunction(instance, "parquet_scan");
auto parquet_scan_copy = parquet_scan.functions;

Expand Down

0 comments on commit 4740aa1

Please sign in to comment.