Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With DuckDB's new logging infra, we can hook up the delta logging to the DuckDB logger to allow us to expose the kernel logging in a clean way to DuckDB users.
To enable:
will now show entries such as:
Note that the 'delta_kernel_logging' setting was added to explicitly enable kernel log forwarding, because enabling them by default might be potentially expensive even if DuckDB logging is enabled. Also note that disabling kernel logging forwarding is not possible because the ffi has no way of unregistering the callback.