Build duckdb_java linux-amd64-musl #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
reviewed
Jan 8, 2025
| image: alpine:latest | ||
| env: | ||
| GEN: ninja | ||
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true |
There was a problem hiding this comment.
Suggested change
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true |
I think this is no more supported / not useful
Comment on lines
+67
to
+86
| # Check if the current system is Alpine Linux | ||
| function(is_alpine_linux RESULT) | ||
| if(UNIX AND NOT APPLE) | ||
| if(EXISTS "/etc/os-release") | ||
| file(READ "/etc/os-release" OS_RELEASE_CONTENTS) | ||
| string(FIND "${OS_RELEASE_CONTENTS}" "Alpine Linux" ALPINE_FOUND) | ||
|
|
||
| if(ALPINE_FOUND GREATER -1) | ||
| set(${RESULT} TRUE PARENT_SCOPE) | ||
| else() | ||
| set(${RESULT} FALSE PARENT_SCOPE) | ||
| endif() | ||
| else() | ||
| set(${RESULT} FALSE PARENT_SCOPE) | ||
| endif() | ||
| else() | ||
| set(${RESULT} FALSE PARENT_SCOPE) | ||
| endif() | ||
| endfunction() | ||
|
|
There was a problem hiding this comment.
Nice! Would you mind sending a PR with this also to duckdb/duckdb ?
Current detection is somehow worse, I think this might be handy in general.
Mause
reviewed
Jan 14, 2025
| @@ -107,7 +107,7 @@ jobs: | |||
| # ./scripts/upload-assets-to-staging.sh github_release duckdb_jdbc-linux-aarch64.jar | |||
|
|
|||
| - uses: actions/upload-artifact@v3 | |||
| with: | |||
| with: duckdb_jdbc-linux-aarch64 | |||
There was a problem hiding this comment.
this doesn't look valid, can you please remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build duckdb_java for Alpine linux on amd64
(arm64 is possible but takes 4+ hours on the default GHA runner, so skipping for now)