Not using Random Device in DuckDB Core #15540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
… on linux instead of time based
Mytherin
reviewed
Jan 9, 2025
Mytherin
reviewed
Jan 9, 2025
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jan 9, 2025
Not using Random Device in DuckDB Core (duckdb/duckdb#15540)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jan 9, 2025
Not using Random Device in DuckDB Core (duckdb/duckdb#15540) Co-authored-by: krlmlr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random Device has different interfaces and libc++ and in libstdc++, this can cause symbol collisions with other libraries.
This PR removes the usage of random device and checks the symbols are not exported in CI.
It is most likely necessary to also amend extensions that might use and export this symbol.
Fix: duckdb/duckdb-java#14
Fix: #8708