Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cmake version for linux_arm64 #129

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

Maxxen
Copy link
Member

@Maxxen Maxxen commented Jan 14, 2025

When compiling duckdb-spatial with the latest extension-ci-tools, linux_arm64 have started failing. Upon further investigation it seems like upgrading the CMake version is the culprit. Specifically, CMake 3.21 is ok, but >= 3.25 breaks.

duckdb-spatial is a bit different than other extension builds in that it doesn't entirely rely on Vcpkg for dependencies but also builds some dependencies using the "recursive cmake" technique. My guess is that something changed in cmake that affected how variables are passed down/interpreted from/to subprocesses which causes the cross-compilation toolchain to be misconfigured for the nested cmake projects, causing them to compile with the host toolchain, which eventually leads to linking errors.

We should eventually move the rest of spatial to use only vcpkg (I tried, but GDAL doesn't build out-of-the box on the community triplets such as mingw64/wasm) and/or bisect this further, but for now the simplest solution is to downgrade the CMake version we use for this arch.

Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@carlopi carlopi merged commit b6afab6 into duckdb:main Jan 14, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants