Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update headers to download correct headers #131

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

samansmink
Copy link
Collaborator

This allows automatically fetching the headers that are configured using TARGET_DUCKDB_VERSION.

So imagine I want to build an extension specifically for the latest unstable version of duckdb in pip which happens to be commit 5d02d69e5c. The process will be:

First set these variables in the makefile (or pass them to it)

  • TARGET_DUCKDB_VERSION=5d02d69e5c
  • USE_UNSTABLE_C_API=1
  • DUCKDB_TEST_VERSION=1.1.4.dev4889

Then:

# installs duckdb==1.1.4.dev4889 and sqllogictestrunner through pip
make configure
# fetches the correct version of duckdb.h and duckdb_extension.h
make update_duckdb_headers
# Builds the extension of abi_type C_STRUCT_UNSTABLE
make debug
# Run the tests on the extension
make test_debug

@samansmink samansmink requested a review from carlopi January 24, 2025 12:48
@samansmink samansmink merged commit 70a6987 into duckdb:main Jan 24, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants