Code

Enum type support#193

Code

Open

Tishj wants to merge 18 commits intomainduckdb/pg_duckdb:mainfrom enum_type_supportduckdb/pg_duckdb:enum_type_supportCopy head branch name to clipboard

+578-13

Commits

Commits on Sep 18, 2024

• add postgres -> duckdb conversion for ENUM types, still need the reverse

  Tishj

  committed
  1e77b66

  Copy full SHA for 1e77b66

• vendor EnumTypeInfoTemplated (lives in a cpp file..), subclass it as PGDuckDBEnumTypeInfo to inject the postgres enum OID

  Tishj

  committed
  22aae7b

  Copy full SHA for 22aae7b

• duckdb -> postgres binding, return the type_oid we saved earlier

  Tishj

  committed
  bda3e7f

  Copy full SHA for bda3e7f

• nearly there, the TupleTableSlot needs to be populated with the OID of the enum member (not the enum type oid)

  Tishj

  committed
  3cdef4e

  Copy full SHA for 3cdef4e

Commits on Sep 19, 2024

• fixed the last problem, we can now consume enums from postgres and roundtrip these back from duckdb -> postgres in the final result

  Tishj

  committed
  5672b48

  Copy full SHA for 5672b48

• add test + make format

  Tishj

  committed
  95ad243

  Copy full SHA for 95ad243

• move into pgduckdb_enum

  Tishj

  committed
  161e52a

  Copy full SHA for 161e52a

• add explanation comments

  Tishj

  committed
  5eab0b5

  Copy full SHA for 5eab0b5

• Merge branch 'main' into enum_type_support

  Tishj

  committed
  1eb2d28

  Copy full SHA for 1eb2d28

• added guards

  Tishj

  committed
  d2f1bb0

  Copy full SHA for d2f1bb0

Commits on Sep 20, 2024

• fix sortorder issue

  Tishj

  committed
  0c216c0

  Copy full SHA for 0c216c0

• dont use elog(ERROR, ..) in duckdb execution path

  Tishj

  committed
  9eed6e6

  Copy full SHA for 9eed6e6

• last mentions of

  Show description for bb889f9
  Tishj

  committed
  bb889f9

  Copy full SHA for bb889f9

• move the implementation details to 'pgduckdb_enum.cpp'

  Tishj

  committed
  bdfe799

  Copy full SHA for bdfe799

• explain the implementation details

  Tishj

  committed
  b46c909

  Copy full SHA for b46c909

Commits on Sep 24, 2024

• Merge branch 'main' into enum_type_support

  Tishj

  committed
  1ad91e7

  Copy full SHA for 1ad91e7

• add filtering for enums

  Tishj

  committed
  bd7d698

  Copy full SHA for bd7d698

• added an id column for verification purposes

  Tishj

  committed
  0ef8cc2

  Copy full SHA for 0ef8cc2