Fix rule validation issues

duckduckgo · Jan 29, 2025 · 678895e · 678895e
1 parent 8a7631f
commit 678895e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/lib/rules.ts b/lib/rules.ts
@@ -14,6 +14,7 @@ export type AutoConsentCMPRule = {
     optIn: AutoConsentRuleStep[];
     openCmp?: AutoConsentRuleStep[];
     test?: AutoConsentRuleStep[];
+    comment?: string;
 };
 
 export type RunContext = {
@@ -24,7 +25,7 @@ export type RunContext = {
 
 export type ElementSelector = string | string[];
 
-export type AutoConsentRuleStep = { optional?: boolean } & Partial<ElementExistsRule> &
+export type AutoConsentRuleStep = { optional?: boolean; comment?: string } & Partial<ElementExistsRule> &
     Partial<ElementVisibleRule> &
     Partial<EvalRule> &
     Partial<WaitForRule> &

diff --git a/rules/autoconsent/dsgvo.json b/rules/autoconsent/dsgvo.json
@@ -1,6 +1,6 @@
 {
     "name": "WP DSGVO Tools",
-    "link": "https://wordpress.org/plugins/shapepress-dsgvo/",
+    "vendorUrl": "https://wordpress.org/plugins/shapepress-dsgvo/",
     "prehideSelectors": [".sp-dsgvo"],
     "cosmetic": true,
     "detectCmp": [{ "exists": ".sp-dsgvo.sp-dsgvo-popup-overlay" }],

diff --git a/rules/autoconsent/johnlewis.json b/rules/autoconsent/johnlewis.json
@@ -5,7 +5,7 @@
     "detectPopup": [{ "exists": "div[class^=pecr-cookie-banner-]" }],
     "optOut": [
         { "click": "button[data-test^=manage-cookies]" },
-        { "wait": "500" },
+        { "wait": 500 },
         {
             "click": "label[data-test^=toggle][class*=checked]:not([class*=disabled])",
             "all": true,

diff --git a/rules/autoconsent/true-car.json b/rules/autoconsent/true-car.json
@@ -4,7 +4,7 @@
         "urlPattern": "^https://www\\.truecar\\.com/"
     },
     "cosmetic": true,
-    "prehideSelectors": [["div[aria-labelledby=\"cookie-banner-heading\"]"]],
+    "prehideSelectors": ["div[aria-labelledby=\"cookie-banner-heading\"]"],
     "detectCmp": [{ "exists": "div[aria-labelledby=\"cookie-banner-heading\"]" }],
     "detectPopup": [{ "visible": "div[aria-labelledby=\"cookie-banner-heading\"]" }],
     "optIn": [{ "click": "div[aria-labelledby=\"cookie-banner-heading\"] > button[aria-label=\"Close\"]" }],

diff --git a/rules/autoconsent/twitter.json b/rules/autoconsent/twitter.json
@@ -15,6 +15,5 @@
         {
             "waitForThenClick": "[data-testid=\"BottomBar\"] > div:has(>div:first-child>div:last-child>button[role=button]>span) > div:last-child > button[role=button]:last-child"
         }
-    ],
-    "TODOtest": [{ "eval": "EVAL_document.cookie.includes('d_prefs=MjoxLGNvbnNlbnRfdmVyc2lvbjoy')" }]
+    ]
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,6 +15,5 @@ @@
             {
                 "waitForThenClick": "[data-testid=\"BottomBar\"] > div:has(>div:first-child>div:last-child>button[role=button]>span) > div:last-child > button[role=button]:last-child"
             }
-        ],
-        "TODOtest": [{ "eval": "EVAL_document.cookie.includes('d_prefs=MjoxLGNvbnNlbnRfdmVyc2lvbjoy')" }]
+        ]
     }