Skip to content

Commit

Permalink
Lint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sammacbeth committed Jan 24, 2025
1 parent 2b6e4cc commit a006817
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 14 deletions.
7 changes: 4 additions & 3 deletions shared/js/background/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import initReloader from './devbuild-reloader';
import tabManager from './tab-manager';
import AbnExperimentMetrics from './components/abn-experiments';
import MessageRouter from './components/message-router';
import { AppUseMetric, SearchMetric, DashboardUseMetric, RefreshMetric } from './metrics'
import { AppUseMetric, SearchMetric, DashboardUseMetric, RefreshMetric } from './metrics';
// NOTE: this needs to be the first thing that's require()d when the extension loads.
// otherwise FF might miss the onInstalled event
require('./events');
Expand Down Expand Up @@ -87,8 +87,9 @@ if (BUILD_TARGET === 'chrome' || BUILD_TARGET === 'chrome-mv2') {
new SearchMetric({ abnMetrics }),
new DashboardUseMetric({ abnMetrics, messaging: components.messaging }),
new RefreshMetric({
abnMetrics, tabTracking: components.tabTracking
})
abnMetrics,
tabTracking: components.tabTracking,
}),
];
components.fireButton = new FireButton({ settings, tabManager });
}
Expand Down
10 changes: 5 additions & 5 deletions shared/js/background/components/message-router.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ import { getBrowserName } from '../utils';

export class MessageReceivedEvent extends CustomEvent {
constructor(msg) {
super('messageReceived', { detail: msg })
super('messageReceived', { detail: msg });
}

get messageType() {
return this.detail.messageType
return this.detail.messageType;
}
}

Expand All @@ -25,7 +25,7 @@ let activePort = null;
export default class MessageRouter extends EventTarget {
constructor({ tabManager }) {
super();
const browserName = getBrowserName()
const browserName = getBrowserName();
// Handle popup UI (aka privacy dashboard) messaging.
browser.runtime.onConnect.addListener((port) => {
if (port.name === 'privacy-dashboard') {
Expand Down Expand Up @@ -59,7 +59,7 @@ export default class MessageRouter extends EventTarget {
}

if (req.messageType && req.messageType in messageHandlers) {
this.dispatchEvent(new MessageReceivedEvent(req))
this.dispatchEvent(new MessageReceivedEvent(req));
return Promise.resolve(messageHandlers[req.messageType](req.options, sender, req));
}

Expand Down Expand Up @@ -106,7 +106,7 @@ export default class MessageRouter extends EventTarget {
console.error('Unrecognized message (privacy-dashboard -> background):', message);
return;
}
this.dispatchEvent(new MessageReceivedEvent(message))
this.dispatchEvent(new MessageReceivedEvent(message));

const response = await messageHandlers[messageType](message?.options, port, message);
if (typeof message?.id === 'number') {
Expand Down
4 changes: 2 additions & 2 deletions shared/js/background/components/tab-tracking.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default class TabTracker extends EventTarget {
* }} options
*/
constructor({ tabManager, devtools }) {
super()
super();
this.tabManager = tabManager;
this.createdTargets = new Map();

Expand Down Expand Up @@ -70,7 +70,7 @@ export default class TabTracker extends EventTarget {
const currentTab = tabManager.get({ tabId: details.tabId });
const newTab = tabManager.create({ tabId: details.tabId, url: details.url });
if (currentTab && currentTab.site.url === details.url) {
this.dispatchEvent(new CustomEvent('tabRefresh', { detail: details }))
this.dispatchEvent(new CustomEvent('tabRefresh', { detail: details }));
}

if (BUILD_TARGET === 'chrome') {
Expand Down
2 changes: 1 addition & 1 deletion shared/js/background/components/tds.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default class TDSStorage {
{ settings },
);
this.remoteConfig.onUpdate(() => {
setTimeout(this.checkShouldOverrideTDS.bind(this), 1)
setTimeout(this.checkShouldOverrideTDS.bind(this), 1);
});
}

Expand Down
6 changes: 3 additions & 3 deletions shared/js/devtools/rollouts.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ async function render() {
cells[2].innerText = f.hasTargets ? 'Yes' : 'No';
cells[3].innerText = f.rolloutPercent ? f.rolloutPercent : '-';
cells[4].innerText = f.rolloutRoll ? Math.floor(f.rolloutRoll) : '-';
cells[5].innerText = (f.hasCohorts && f.cohort) ? f.cohort.name : '-';
cells[6].innerText = (f.cohort && f.cohort.assignedAt) ? new Date(f.cohort.assignedAt).toISOString().slice(0, 10) : '';
cells[7].innerText = (f.cohort && f.cohort.enrolledAt) ? new Date(f.cohort.enrolledAt).toISOString().slice(0, 10) : '';
cells[5].innerText = f.hasCohorts && f.cohort ? f.cohort.name : '-';
cells[6].innerText = f.cohort && f.cohort.assignedAt ? new Date(f.cohort.assignedAt).toISOString().slice(0, 10) : '';
cells[7].innerText = f.cohort && f.cohort.enrolledAt ? new Date(f.cohort.enrolledAt).toISOString().slice(0, 10) : '';
const actionsCell = cells[8];
if (f.hasRollout && f.rolloutRoll) {
const resetRollout = document.createElement('button');
Expand Down

0 comments on commit a006817

Please sign in to comment.