Reduce release page size.

100 is overkill, we’ll almost never need to look deeper than 25 releases.
duckduckgo · Jan 28, 2025 · 828c215 · 828c215
1 parent c42fd00
commit 828c215
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/lib/fastlane/plugin/ddg_apple_automation/helper/git_helper.rb b/lib/fastlane/plugin/ddg_apple_automation/helper/git_helper.rb
@@ -82,7 +82,7 @@ def self.latest_release(repo_name, prerelease, platform = nil, github_token)
         client = Octokit::Client.new(access_token: github_token)
 
         current_page = 1
-        page_size = 100
+        page_size = 25
 
         loop do
           releases = client.releases(repo_name, per_page: page_size, page: current_page)

diff --git a/spec/asana_helper_spec.rb b/spec/asana_helper_spec.rb
@@ -242,8 +242,8 @@ def sanitize_asana_html_notes(content)
     before do
       @client = double("Octokit::Client")
       allow(Octokit::Client).to receive(:new).and_return(@client)
-      allow(@client).to receive(:releases).with("iOS", { page: 1, per_page: 100 }).and_return([double(tag_name: "7.122.0", prerelease: false)])
-      allow(@client).to receive(:releases).with("iOS", { page: 2, per_page: 100 }).and_return([])
+      allow(@client).to receive(:releases).with("iOS", { page: 1, per_page: 25 }).and_return([double(tag_name: "7.122.0", prerelease: false)])
+      allow(@client).to receive(:releases).with("iOS", { page: 2, per_page: 25 }).and_return([])
       allow(Fastlane::Helper::GitHelper).to receive(:repo_name).and_return("iOS")
 
       @asana_client = double("Asana::Client")
@@ -264,7 +264,7 @@ def sanitize_asana_html_notes(content)
     end
 
     it "completes the update of Asana tasks for internal release" do
-      expect(@client).to receive(:releases).with("iOS", { page: 1, per_page: 100 })
+      expect(@client).to receive(:releases).with("iOS", { page: 1, per_page: 25 })
 
       expect(Fastlane::Helper::AsanaHelper).to receive(:fetch_release_notes).with("1234567890", "secret-token")
       expect(Fastlane::Helper::ReleaseTaskHelper).to receive(:construct_release_task_description).with("Release notes content", ["1234567890"])

diff --git a/spec/git_helper_spec.rb b/spec/git_helper_spec.rb
@@ -87,7 +87,7 @@
       let(:prerelease) { false }
 
       before do
-        allow(client).to receive(:releases).with(repo_name, per_page: 100, page: 1).and_return(
+        allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
           [
             double(tag_name: "2.0.0+macos", prerelease: false),
             double(tag_name: "1.0.0+macos", prerelease: false)
@@ -107,7 +107,7 @@
         let(:prerelease) { true }
 
         before do
-          allow(client).to receive(:releases).with(repo_name, per_page: 100, page: 1).and_return(
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
             [
               double(tag_name: "1.2.3-4", prerelease: true),
               double(tag_name: "1.2.2-3", prerelease: true),
@@ -125,7 +125,7 @@
         let(:prerelease) { false }
 
         before do
-          allow(client).to receive(:releases).with(repo_name, per_page: 100, page: 1).and_return(
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
             [
               double(tag_name: "2.0.0-1", prerelease: true),
               double(tag_name: "1.0.0", prerelease: false),
@@ -147,7 +147,7 @@
         let(:prerelease) { true }
 
         before do
-          allow(client).to receive(:releases).with(repo_name, per_page: 100, page: 1).and_return(
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
             [
               double(tag_name: "1.0.0-1+macos", prerelease: true),
               double(tag_name: "2.0.0-1+ios", prerelease: true),
@@ -165,7 +165,7 @@
         let(:prerelease) { false }
 
         before do
-          allow(client).to receive(:releases).with(repo_name, per_page: 100, page: 1).and_return(
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
             [
               double(tag_name: "1.0.0+macos", prerelease: false),
               double(tag_name: "1.0.0+ios", prerelease: false),