Update release fetching to optionally match tags with a platform component

lib/fastlane/plugin/ddg_apple_automation/actions/asana_find_release_task_action.rb

@@ -59,10 +59,7 @@ def self.run(params)
       end
 
       def self.find_latest_marketing_version(github_token, platform)
-        client = Octokit::Client.new(access_token: github_token)
-
-        # NOTE: `client.latest_release` returns release marked as "latest", i.e. a public release
-        latest_internal_release = client.releases(Helper::GitHelper.repo_name(platform), { per_page: 1 }).first
+        latest_internal_release = Helper::GitHelper.latest_release(Helper::GitHelper.repo_name(platform), true, github_token)
 
         version = extract_version_from_tag_name(latest_internal_release&.tag_name)
         if version.to_s.empty?

lib/fastlane/plugin/ddg_apple_automation/actions/tag_release_action.rb

@@ -63,8 +63,8 @@ def self.create_tag_and_github_release(is_prerelease, github_token)
         end
 
         begin
-          client = Octokit::Client.new(access_token: github_token)
-          latest_public_release = client.latest_release(@constants[:repo_name])
+          latest_public_release = Helper::GitHelper.latest_release(@constants[:repo_name], false, github_token)
+
           UI.message("Latest public release: #{latest_public_release.tag_name}")
           UI.message("Generating #{@constants[:repo_name]} release notes for GitHub release for tag: #{tag}")
 

lib/fastlane/plugin/ddg_apple_automation/helper/asana_helper.rb

@@ -219,8 +219,8 @@ def self.create_release_task(platform, version, assignee_id, asana_access_token,
       #
       def self.update_asana_tasks_for_internal_release(params)
         UI.message("Checking latest public release in GitHub")
-        client = Octokit::Client.new(access_token: params[:github_token])
-        latest_public_release = client.latest_release(Helper::GitHelper.repo_name(params[:platform]))
+
+        latest_public_release = Helper::GitHelper.latest_release(Helper::GitHelper.repo_name(params[:platform]), false, params[:github_token])
         UI.success("Latest public release: #{latest_public_release.tag_name}")
 
         UI.message("Extracting task IDs from git log since #{latest_public_release.tag_name} release")

lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb

@@ -157,8 +157,7 @@ def self.prepare_release_branch(platform, version, other_action)
       end
 
       def self.prepare_hotfix_branch(github_token, platform, other_action, options)
-        client = Octokit::Client.new(access_token: github_token)
-        latest_public_release = client.latest_release(Helper::GitHelper.repo_name(platform))
+        latest_public_release = Helper::GitHelper.latest_release(Helper::GitHelper.repo_name(platform), false, github_token)
         version = latest_public_release.tag_name
         Helper::GitHubActionsHelper.set_output("last_release", version)
         UI.user_error!("Unable to find latest release to hotfix") unless version

lib/fastlane/plugin/ddg_apple_automation/helper/git_helper.rb

@@ -77,6 +77,31 @@ def self.assert_branch_has_changes(release_branch)
 
         changed_files.any?
       end
+
+      def self.latest_release(repo_name, prerelease, platform = nil, github_token)
+        client = Octokit::Client.new(access_token: github_token)
+
+        current_page = 1
+        page_size = 25
+
+        loop do
+          releases = client.releases(repo_name, per_page: page_size, page: current_page)
+          break if releases.empty?
+
+          # If `prerelease` is true, return the latest release that matches the platform regardless of whether it's public.
+          # If `prerelease` is false, then ensure that the release is public.
+          matching_release = releases.find do |release|
+            (prerelease || !release.prerelease) && (platform.nil? || release.tag_name.end_with?("+#{platform}"))
+          end
+
+          return matching_release if matching_release
+          break if releases.size < page_size
+
+          current_page += 1
+        end
+
+        return nil
+      end
     end
   end
 end

spec/asana_find_release_task_action_spec.rb

@@ -35,9 +35,17 @@ def test_action(platform)
     end
 
     it "returns the latest marketing version" do
-      allow(@client).to receive(:releases).and_return([double(tag_name: '1.0.0')])
-
-      expect(find_latest_marketing_version).to eq("1.0.0")
+      allow(@client).to receive(:releases).and_return(
+        [
+          double(tag_name: '2.0.0-1', prerelease: true),
+          double(tag_name: '2.0.0-0', prerelease: true),
+          double(tag_name: '1.0.0', prerelease: false),
+          double(tag_name: '1.0.0-1', prerelease: true),
+          double(tag_name: '1.0.0-0', prerelease: true)
+        ]
+      )
+
+      expect(find_latest_marketing_version).to eq("2.0.0")
     end
 
     describe "when there is no latest release" do
@@ -53,7 +61,7 @@ def test_action(platform)
 
     describe "when latest release is not a valid semver" do
       it "shows error" do
-        allow(@client).to receive(:releases).and_return([double(tag_name: '1.0')])
+        allow(@client).to receive(:releases).and_return([double(tag_name: '1.0', prerelease: false)])
         allow(Fastlane::UI).to receive(:user_error!)
 
         find_latest_marketing_version

spec/asana_helper_spec.rb

@@ -242,7 +242,8 @@ def sanitize_asana_html_notes(content)
     before do
       @client = double("Octokit::Client")
       allow(Octokit::Client).to receive(:new).and_return(@client)
-      allow(@client).to receive(:latest_release).and_return(double(tag_name: "7.122.0"))
+      allow(@client).to receive(:releases).with("iOS", { page: 1, per_page: 25 }).and_return([double(tag_name: "7.122.0", prerelease: false)])
+      allow(@client).to receive(:releases).with("iOS", { page: 2, per_page: 25 }).and_return([])
       allow(Fastlane::Helper::GitHelper).to receive(:repo_name).and_return("iOS")
 
       @asana_client = double("Asana::Client")
@@ -263,7 +264,7 @@ def sanitize_asana_html_notes(content)
     end
 
     it "completes the update of Asana tasks for internal release" do
-      expect(@client).to receive(:latest_release).with("iOS")
+      expect(@client).to receive(:releases).with("iOS", { page: 1, per_page: 25 })
 
       expect(Fastlane::Helper::AsanaHelper).to receive(:fetch_release_notes).with("1234567890", "secret-token")
       expect(Fastlane::Helper::ReleaseTaskHelper).to receive(:construct_release_task_description).with("Release notes content", ["1234567890"])

spec/ddg_apple_automation_helper_spec.rb

@@ -282,7 +282,7 @@ def load_file(file)
 
       @client = double("Octokit::Client")
       allow(Octokit::Client).to receive(:new).and_return(@client)
-      allow(@client).to receive(:latest_release).and_return(double(tag_name: source_version))
+      allow(@client).to receive(:releases).and_return([double(tag_name: source_version, prerelease: false)])
       allow(Fastlane::Helper::GitHelper).to receive(:repo_name).and_return("macOS")
 
       allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:validate_version_exists)
@@ -332,7 +332,7 @@ def load_file(file)
 
       @client = double("Octokit::Client")
       allow(Octokit::Client).to receive(:new).and_return(@client)
-      allow(@client).to receive(:latest_release).and_return(double(tag_name: source_version))
+      allow(@client).to receive(:releases).and_return([double(tag_name: source_version, prerelease: false)])
       allow(Fastlane::Helper::GitHelper).to receive(:repo_name).and_return("iOS")
 
       allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:validate_version_exists)

spec/git_helper_spec.rb

@@ -76,4 +76,108 @@
       end
     end
   end
+
+  describe "#latest_release" do
+    subject { Fastlane::Helper::GitHelper.latest_release(repo_name, prerelease, platform, github_token) }
+
+    include_context "common setup"
+
+    context "when no releases matching platform are found" do
+      let(:platform) { "ios" }
+      let(:prerelease) { false }
+
+      before do
+        allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
+          [
+            double(tag_name: "2.0.0+macos", prerelease: false),
+            double(tag_name: "1.0.0+macos", prerelease: false)
+          ]
+        )
+      end
+
+      it "returns nil" do
+        expect(subject).to be_nil
+      end
+    end
+
+    context "when platform is not provided" do
+      let(:platform) { nil }
+
+      context "and prerelease is true" do
+        let(:prerelease) { true }
+
+        before do
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
+            [
+              double(tag_name: "1.2.3-4", prerelease: true),
+              double(tag_name: "1.2.2-3", prerelease: true),
+              double(tag_name: "1.2.3", prerelease: false)
+            ]
+          )
+        end
+
+        it "returns the latest prerelease" do
+          expect(subject.tag_name).to eq("1.2.3-4")
+        end
+      end
+
+      context "and prerelease is false" do
+        let(:prerelease) { false }
+
+        before do
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
+            [
+              double(tag_name: "2.0.0-1", prerelease: true),
+              double(tag_name: "1.0.0", prerelease: false),
+              double(tag_name: "1.0.0-1", prerelease: true)
+            ]
+          )
+        end
+
+        it "returns the latest full release" do
+          expect(subject.tag_name).to eq("1.0.0")
+        end
+      end
+    end
+
+    context "when platform is provided" do
+      let(:platform) { "ios" }
+
+      context "and prerelease is true" do
+        let(:prerelease) { true }
+
+        before do
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
+            [
+              double(tag_name: "1.0.0-1+macos", prerelease: true),
+              double(tag_name: "2.0.0-1+ios", prerelease: true),
+              double(tag_name: "1.0.0-1+ios", prerelease: true)
+            ]
+          )
+        end
+
+        it "returns the latest prerelease with the platform suffix" do
+          expect(subject.tag_name).to eq("2.0.0-1+ios")
+        end
+      end
+
+      context "and prerelease is false" do
+        let(:prerelease) { false }
+
+        before do
+          allow(client).to receive(:releases).with(repo_name, per_page: 25, page: 1).and_return(
+            [
+              double(tag_name: "1.0.0+macos", prerelease: false),
+              double(tag_name: "1.0.0+ios", prerelease: false),
+              double(tag_name: "1.0.0-1+ios", prerelease: true)
+            ]
+          )
+        end
+
+        it "returns the latest full release with the platform suffix" do
+          expect(subject.tag_name).to eq("1.0.0+ios")
+        end
+      end
+    end
+  end
 end

spec/tag_release_action_spec.rb

@@ -105,10 +105,10 @@
   describe "#create_tag_and_github_release" do
     subject { Fastlane::Actions::TagReleaseAction.create_tag_and_github_release(@params[:is_prerelease], @params[:github_token]) }
 
-    let (:latest_public_release) { double(tag_name: "1.0.0") }
+    let (:latest_public_release) { double(tag_name: "1.0.0", prerelease: false) }
     let (:generated_release_notes) { { body: { "name" => "1.1.0", "body" => "Release notes" } } }
     let (:other_action) { double(add_git_tag: nil, push_git_tags: nil, github_api: generated_release_notes, set_github_release: nil) }
-    let (:octokit_client) { double(latest_release: latest_public_release) }
+    let (:octokit_client) { double(releases: [latest_public_release]) }
 
     shared_context "local setup" do
       before(:each) do
@@ -174,7 +174,7 @@
 
     shared_context "when failed to fetch latest GitHub release" do
       before do
-        allow(octokit_client).to receive(:latest_release).and_raise(StandardError)
+        allow(octokit_client).to receive(:releases).and_raise(StandardError)
       end
     end