Update workflow names to include platform (#3799)

Task/Issue URL: https://app.asana.com/0/72649045549333/1209141686015372/f Tech Design URL: CC: Description: This PR makes the following changes: Renames workflow files to be prefixed by ios- Updates references to workflow files to account for this renaming - only one rename was needed, within ios-nightly.yml
duckduckgo · Jan 14, 2025 · b7bdaa4 · b7bdaa4
1 parent f0f23ad
commit b7bdaa4
Show file tree

Hide file tree

Showing 12 changed files with 35 additions and 39 deletions.
diff --git a/.github/workflows/adhoc.yml → .github/workflows/ios-adhoc.yml b/.github/workflows/adhoc.yml → .github/workflows/ios-adhoc.yml
@@ -1,4 +1,4 @@
-name: Make ad-hoc build
+name: iOS - Make ad-hoc build
 
 on:
   workflow_dispatch:
@@ -53,7 +53,7 @@ jobs:
           if [[ "${{ github.event.inputs.build-type }}" == "Release" ]]; then
             lane_to_use="release_adhoc"
           fi
-          
+
           if [[ -n "${{ github.event.inputs.suffix }}" ]]; then
             bundle exec fastlane ${lane_to_use} suffix:${{ github.event.inputs.suffix }}
           else
@@ -81,7 +81,7 @@ jobs:
         with:
           name: ${{ env.dsyms_filename }}
           path: ${{ env.dsyms_path }}
-      
+
       - name: Get Asana Task ID
         id: get-task-id
         if: github.event.inputs.asana-task-url

diff --git a/.github/workflows/alpha.yml → .github/workflows/ios-alpha.yml b/.github/workflows/alpha.yml → .github/workflows/ios-alpha.yml
@@ -1,4 +1,4 @@
-name: Make TestFlight Alpha Build
+name: iOS - Make TestFlight Alpha Build
 
 on:
   workflow_dispatch:

diff --git a/.github/workflows/danger.yml → .github/workflows/ios-danger.yml b/.github/workflows/danger.yml → .github/workflows/ios-danger.yml
@@ -1,5 +1,5 @@
-name: Danger JS
-on: 
+name: iOS - Danger JS
+on:
   pull_request:
     types: [labeled, unlabeled, opened, reopened, edited, synchronize]
 

diff --git a/.github/workflows/end-to-end.yml → .github/workflows/ios-end-to-end.yml b/.github/workflows/end-to-end.yml → .github/workflows/ios-end-to-end.yml
@@ -1,4 +1,4 @@
-name: End-to-End tests
+name: iOS - End-to-End tests
 
 on:
   schedule:
@@ -10,7 +10,7 @@ jobs:
     name: Build End to End Tests
     runs-on: macos-15-xlarge
     timeout-minutes: 30
-    
+
     steps:
     - name: Check out the code
       uses: actions/checkout@v3
@@ -54,7 +54,7 @@ jobs:
       with:
         name: duckduckgo-ios-app
         path: DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app
-    
+
     - name: Upload logs when workflow failed
       uses: actions/upload-artifact@v4
       if: failure() || cancelled()
@@ -73,7 +73,7 @@ jobs:
     strategy:
       matrix:
         test-tag: [release, privacy, securityTest, adClick]
-      max-parallel: 1 # Uncomment this line to run tests sequentially. 
+      max-parallel: 1 # Uncomment this line to run tests sequentially.
       fail-fast: false
 
     steps:
@@ -94,7 +94,7 @@ jobs:
     - name: End to End tests
       run: |
         export PATH="$PATH":"$HOME/.maestro/bin"; maestro cloud --apiKey ${{ secrets.ROBIN_API_KEY }} --project-id ${{ secrets.ROBIN_PROJECT_KEY }} -e ONBOARDING_COMPLETED=true --fail-on-timeout=true --fail-on-cancellation=true --timeout=150 --ios-version=17 --include-tags=${{ matrix.test-tag }} DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app .maestro/
-  
+
   # notify-failure:
   #   name: Notify on failure
   #   if: ${{ always() && contains(join(needs.*.result, ','), 'failure') && github.ref_name == 'main' }}

diff --git a/.github/workflows/nightly.yml → .github/workflows/ios-nightly.yml b/.github/workflows/nightly.yml → .github/workflows/ios-nightly.yml
@@ -1,4 +1,4 @@
-name: Nightly Test and Deploy
+name: iOS - Nightly Test and Deploy
 
 on:
   schedule:
@@ -100,7 +100,7 @@ jobs:
 
   deploy-alpha:
     name: Deploy Nightly Alpha Build
-    uses: ./.github/workflows/alpha.yml
+    uses: ./.github/workflows/ios-alpha.yml
     with:
       destination: "Nightly Alpha Group"
     secrets:

diff --git a/.github/workflows/pr.yml → .github/workflows/ios-pr-checks.yml b/.github/workflows/pr.yml → .github/workflows/ios-pr-checks.yml
@@ -1,4 +1,4 @@
-name: PR Checks
+name: iOS - PR Checks
 
 on:
   push:

diff --git a/.github/workflows/pr-labels.yml → .github/workflows/ios-pr-labels.yml b/.github/workflows/pr-labels.yml → .github/workflows/ios-pr-labels.yml
@@ -1,4 +1,4 @@
-name: PR Labels
+name: iOS - PR Labels
 
 on:
   push:

diff --git a/.github/workflows/pr-task-url.yml → .github/workflows/ios-pr-task-url.yml b/.github/workflows/pr-task-url.yml → .github/workflows/ios-pr-task-url.yml
@@ -1,6 +1,6 @@
-name: Asana PR Task URL
+name: iOS - Asana PR Task URL
 
-on: 
+on:
   pull_request:
     types: [opened, edited, closed, synchronize, review_requested, ready_for_review]
 

diff --git a/.github/workflows/promote_testflight.yml → .github/workflows/ios-promote-testflight.yml b/.github/workflows/promote_testflight.yml → .github/workflows/ios-promote-testflight.yml
@@ -1,6 +1,6 @@
-name: Promote TestFlight to App Store
+name: iOS - Promote TestFlight to App Store
 
-on: 
+on:
   workflow_dispatch: {}
 
 jobs:

diff --git a/.github/workflows/release.yml → .github/workflows/ios-release.yml b/.github/workflows/release.yml → .github/workflows/ios-release.yml
@@ -1,4 +1,4 @@
-name: Make App Store Connect Release
+name: iOS - Make App Store Connect Release
 
 on:
   workflow_dispatch:
@@ -92,10 +92,10 @@ jobs:
         else
           echo "::error::Asana Task URL has incorrect format (attempted to match ${task_url_regex})."
         fi
-        
+
     - name: Upload debug symbols to Asana
       if: ${{ always() && github.event.inputs.asana-task-url }}
-      env:     
+      env:
         ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}
       run: |
         if [[ -f ${{ env.dsyms_path }} ]]; then
@@ -129,8 +129,8 @@ jobs:
 
         if [[ -z "${MM_USER_HANDLE}" ]]; then
             echo "Mattermost user handle not known for ${{ github.actor }}, skipping sending message"
-        else            
+        else
             curl -s -H 'Content-type: application/json' \
                 -d "$(envsubst < ./scripts/assets/appstore-release-mm-template.json | jq ".${{ job.status }}")" \
                 ${{ secrets.MM_WEBHOOK_URL }}
-        fi  
+        fi
diff --git a/.github/workflows/stale-pr.yml → .github/workflows/ios-stale-pr.yml b/.github/workflows/stale-pr.yml → .github/workflows/ios-stale-pr.yml
@@ -1,4 +1,4 @@
-name: Close Stale Pull Requests
+name: iOS - Close Stale Pull Requests
 
 on:
   schedule:

diff --git a/.github/workflows/sync-end-to-end.yml → .github/workflows/ios-sync-end-to-end.yml b/.github/workflows/sync-end-to-end.yml → .github/workflows/ios-sync-end-to-end.yml
@@ -1,4 +1,4 @@
-name: Sync-End-to-End tests
+name: iOS - Sync-End-to-End tests
 
 on:
   schedule:
@@ -54,7 +54,7 @@ jobs:
       with:
         name: duckduckgo-ios-app
         path: DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app
-    
+
     - name: Upload logs when workflow failed
       uses: actions/upload-artifact@v4
       if: failure() || cancelled()
@@ -64,7 +64,7 @@ jobs:
           xcodebuild.log
           DerivedData/Logs/Test/*.xcresult
         retention-days: 7
-    
+
   sync-end-to-end-tests:
     name: Sync End To End Tests
     needs: build-for-sync-end-to-end-tests
@@ -73,9 +73,9 @@ jobs:
     strategy:
       matrix:
         os-version: [17] #[15, 16, 17]
-      max-parallel: 1 # Uncomment this line to run tests sequentially. 
+      max-parallel: 1 # Uncomment this line to run tests sequentially.
       fail-fast: false
-    
+
     steps:
     - name: Check out the code
       uses: actions/checkout@v3 # Don't need submodules here as this is only for the tests folder
@@ -85,7 +85,7 @@ jobs:
       id: sync-recovery-code
       with:
         debug: true
-    
+
     - name: Retrieve Binary
       uses: actions/download-artifact@v4
       with:
@@ -95,19 +95,19 @@ jobs:
     - name: Install Maestro
       run: |
         export MAESTRO_VERSION=1.39.1; curl -Ls "https://get.maestro.mobile.dev" | bash
-        
+
     - name: Overwrite default config with sync one
       run: |
         cp .maestro/config-sync .maestro/config.yaml
-        
-    - name: Sync e2e tests 
+
+    - name: Sync e2e tests
       run: |
         export PATH="$PATH":"$HOME/.maestro/bin"; maestro cloud --apiKey ${{ secrets.ROBIN_API_KEY }} --project-id ${{ secrets.ROBIN_PROJECT_KEY }} -e ONBOARDING_COMPLETED=true --env=CODE=${{ steps.sync-recovery-code.outputs.recovery-code }} --fail-on-timeout=true --fail-on-cancellation=true --timeout=150 --ios-version=${{ matrix.os-version }} --include-tags=sync --app-file DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app --flows .maestro/
 
     - name: Reset config
       run: |
         git checkout .maestro/config.yaml
-    
+
   # notify-failure:
   #   name: Notify on failure
   #   if: ${{ always() && contains(join(needs.*.result, ','), 'failure') && github.ref_name == 'main' }}
@@ -122,7 +122,3 @@ jobs:
   #           --header "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \
   #           --header "Content-Type: application/json" \
   #           --data ' { "data": { "name": "GH Workflow Failure - Sync End to end tests", "workspace": "${{ vars.GH_ASANA_WORKSPACE_ID }}", "projects": [ "${{ vars.GH_ASANA_IOS_APP_PROJECT_ID }}" ], "notes" : "The end to end workflow has failed. See https://github.com/duckduckgo/iOS/actions/runs/${{ github.run_id }}" } }'
-
-
-
-