-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows htmlNewTabPage
override, move nextStepsWidget
#2675
base: main
Are you sure you want to change the base?
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
@ayoy Any reason not to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending minSupportedVersion
– perhaps that one isn't needed after all? Depending on whether you've supported the flag in previous versions of the app.
Add me as a reviewer when you have that, I think you'll be blocked by CODEOWNERS etc. |
Generated file outputs:Time updated: Fri, 24 Jan 2025 15:58:32 GMT legacytrackers-unprotected-temporary.txtv3/android-config.json (12 more)
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -6724,8 +6724,11 @@
"exceptions": [],
"features": {
"isLaunched": {
"state": "disabled"
+ },
+ "nextStepsWidget": {
+ "state": "disabled"
}
}
},
"https": {
v3/windows-config.json--- v3/windows-config.json
+++ v3/windows-config.json
@@ -6579,13 +6579,16 @@
"state": "disabled",
"exceptions": []
},
"htmlNewTabPage": {
- "state": "disabled",
+ "state": "internal",
"exceptions": [],
"features": {
"isLaunched": {
- "state": "disabled"
+ "state": "internal"
+ },
+ "nextStepsWidget": {
+ "state": "internal"
}
}
},
"https": {
@@ -11050,14 +11053,9 @@
},
"windowsNewTabPageExperiment": {
"state": "enabled",
"exceptions": [],
- "minSupportedVersion": "0.96.0",
- "features": {
- "nextStepsWidget": {
- "state": "disabled"
- }
- }
+ "minSupportedVersion": "0.96.0"
},
"windowsPermissionUsage": {
"exceptions": [],
"state": "enabled"
latestv4/android-config.json (12 more)
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6146,8 +6146,11 @@
"exceptions": [],
"features": {
"isLaunched": {
"state": "disabled"
+ },
+ "nextStepsWidget": {
+ "state": "disabled"
}
}
},
"https": {
v4/windows-config.json--- v4/windows-config.json
+++ v4/windows-config.json
@@ -6032,13 +6032,16 @@
"state": "disabled",
"exceptions": []
},
"htmlNewTabPage": {
- "state": "disabled",
+ "state": "internal",
"exceptions": [],
"features": {
"isLaunched": {
- "state": "disabled"
+ "state": "internal"
+ },
+ "nextStepsWidget": {
+ "state": "internal"
}
}
},
"https": {
@@ -10049,14 +10052,9 @@
},
"windowsNewTabPageExperiment": {
"state": "enabled",
"exceptions": [],
- "minSupportedVersion": "0.96.0",
- "features": {
- "nextStepsWidget": {
- "state": "disabled"
- }
- }
+ "minSupportedVersion": "0.96.0"
},
"windowsPermissionUsage": {
"exceptions": [],
"state": "enabled"
|
Sorry @jonathanKingston -- we need to re-enable the existing experiment for now so I slipped that change in last minute. |
Asana Task/Github Issue: https://app.asana.com/0/0/1209118039592227/f
Description
htmlNewTabPage
in prep for upcoming launchnextStepsWidget
tohtmlNewTabPage
(since we'll eventually removewindowsNewTabPageExperiment
)Brief explanation
Reference