Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows htmlNewTabPage override, move nextStepsWidget #2675

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

greyivy
Copy link
Contributor

@greyivy greyivy commented Jan 23, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209118039592227/f

Description

  • Adds Windows override for htmlNewTabPage in prep for upcoming launch
  • Moves nextStepsWidget to htmlNewTabPage (since we'll eventually remove windowsNewTabPageExperiment)

Brief explanation

  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions

Reference

@greyivy greyivy requested review from a team as code owners January 23, 2025 01:58
@greyivy greyivy added the DO NOT MERGE Don't merge this branch unless directed label Jan 23, 2025
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

@greyivy greyivy requested review from seldoff and ayoy January 23, 2025 01:58
@greyivy
Copy link
Contributor Author

greyivy commented Jan 23, 2025

@ayoy Any reason not to add nextStepsWidget here?

ayoy
ayoy previously approved these changes Jan 23, 2025
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending minSupportedVersion – perhaps that one isn't needed after all? Depending on whether you've supported the flag in previous versions of the app.

@jonathanKingston
Copy link
Collaborator

Add me as a reviewer when you have that, I think you'll be blocked by CODEOWNERS etc.

@greyivy greyivy removed the DO NOT MERGE Don't merge this branch unless directed label Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

Generated file outputs:

Time updated: Fri, 24 Jan 2025 15:58:32 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (12 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -6724,8 +6724,11 @@
             "exceptions": [],
             "features": {
                 "isLaunched": {
                     "state": "disabled"
+                },
+                "nextStepsWidget": {
+                    "state": "disabled"
                 }
             }
         },
         "https": {
v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -6579,13 +6579,16 @@
             "state": "disabled",
             "exceptions": []
         },
         "htmlNewTabPage": {
-            "state": "disabled",
+            "state": "internal",
             "exceptions": [],
             "features": {
                 "isLaunched": {
-                    "state": "disabled"
+                    "state": "internal"
+                },
+                "nextStepsWidget": {
+                    "state": "internal"
                 }
             }
         },
         "https": {
@@ -11050,14 +11053,9 @@
         },
         "windowsNewTabPageExperiment": {
             "state": "enabled",
             "exceptions": [],
-            "minSupportedVersion": "0.96.0",
-            "features": {
-                "nextStepsWidget": {
-                    "state": "disabled"
-                }
-            }
+            "minSupportedVersion": "0.96.0"
         },
         "windowsPermissionUsage": {
             "exceptions": [],
             "state": "enabled"
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6146,8 +6146,11 @@
             "exceptions": [],
             "features": {
                 "isLaunched": {
                     "state": "disabled"
+                },
+                "nextStepsWidget": {
+                    "state": "disabled"
                 }
             }
         },
         "https": {
v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -6032,13 +6032,16 @@
             "state": "disabled",
             "exceptions": []
         },
         "htmlNewTabPage": {
-            "state": "disabled",
+            "state": "internal",
             "exceptions": [],
             "features": {
                 "isLaunched": {
-                    "state": "disabled"
+                    "state": "internal"
+                },
+                "nextStepsWidget": {
+                    "state": "internal"
                 }
             }
         },
         "https": {
@@ -10049,14 +10052,9 @@
         },
         "windowsNewTabPageExperiment": {
             "state": "enabled",
             "exceptions": [],
-            "minSupportedVersion": "0.96.0",
-            "features": {
-                "nextStepsWidget": {
-                    "state": "disabled"
-                }
-            }
+            "minSupportedVersion": "0.96.0"
         },
         "windowsPermissionUsage": {
             "exceptions": [],
             "state": "enabled"

@greyivy greyivy added the DO NOT MERGE Don't merge this branch unless directed label Jan 24, 2025
@greyivy
Copy link
Contributor Author

greyivy commented Jan 24, 2025

Sorry @jonathanKingston -- we need to re-enable the existing experiment for now so I slipped that change in last minute.

@greyivy greyivy enabled auto-merge January 24, 2025 16:03
@greyivy greyivy disabled auto-merge January 24, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants