Skip to content

Commit

Permalink
ci: disable tests with 8.3 shared library
Browse files Browse the repository at this point in the history
  • Loading branch information
dunglas committed Nov 16, 2023
1 parent 4c70ae2 commit 08ca7ad
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-versions: ['8.2', '8.3']
php-versions: ['8.2'] # 8.3 is disabled because of https://github.com/shivammathur/setup-php/issues/783
steps:
-
uses: actions/checkout@v4
Expand All @@ -30,8 +30,10 @@ jobs:
ini-file: development
coverage: none
tools: none
extensions: none, opcache
env:
phpts: ts
debug: true
-
name: Set CGO flags
run: |
Expand Down
26 changes: 13 additions & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,31 +99,31 @@ docker buildx bake -f docker-bake.hcl --pull --no-cache --push
```
3. Enable `tmate` to connect to the container
```patch
- name: Set include flags
-
name: Set CGO flags
run: echo "CGO_CFLAGS=$(php-config --includes)" >> "$GITHUB_ENV"
+ - run: |
sudo apt install gdb
+ -
+ run: |
+ sudo apt install gdb
+ mkdir -p /home/runner/.config/gdb/
+ printf "set auto-load safe-path /\nhandle SIG34 nostop noprint pass" > /home/runner/.config/gdb/gdbinit
+ - uses: mxschmitt/action-tmate@v3
+ env:
+ GOFLAGS: "-w -gcflags=all=-N -gcflags=all=-l"
+ -
+ uses: mxschmitt/action-tmate@v3
```
4. Open `frankenphp.go`
5. Enable `cgosymbolizer`
4. Connect to the container
5. Open `frankenphp.go`
6. Enable `cgosymbolizer`
```patch
- //_ "github.com/ianlancetaylor/cgosymbolizer"
+ _ "github.com/ianlancetaylor/cgosymbolizer"
```
6. Download the module: `go get`
7. In the container, you can use GDB and the like:
7. Download the module: `go get`
8. In the container, you can use GDB and the like:
```sh
sudo apt install gdb
mkdir -p /home/runner/.config/gdb/
go test -c -ldflags=-w
gdb --args ./frankenphp.test -test.run ^MyTest$
```
8. When the bug is fixed, revert all these changes
9. When the bug is fixed, revert all these changes

## Misc Dev Resources

Expand Down

0 comments on commit 08ca7ad

Please sign in to comment.