Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update artifact actions to v4 #1255

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

vinceAmstoutz
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz commented Dec 18, 2024

Closes #443

The main changes, for v4 compatibility, include the following:

  • Adaptation of the pattern in the download step to handle dynamic names.
  • Considering breaking changes, notably the impossibility of downloading multiple times within the same artifact.

@dunglas
Copy link
Owner

dunglas commented Dec 18, 2024

This will not work. According to https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners you should now use the pattern key of download-artifact instead of the name one.

You'll also have to give a different name to all uploaded artifacts: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

@vinceAmstoutz vinceAmstoutz force-pushed the ci-update-artifacts-actions branch from 7d15ef8 to 89a8f80 Compare December 18, 2024 10:55
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Show resolved Hide resolved
@vinceAmstoutz vinceAmstoutz force-pushed the ci-update-artifacts-actions branch 2 times, most recently from 3966d1d to d425fcc Compare December 18, 2024 13:43
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Outdated Show resolved Hide resolved
vinceAmstoutz and others added 3 commits December 18, 2024 17:42
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
@dunglas dunglas merged commit 85c2735 into dunglas:main Dec 18, 2024
38 checks passed
@dunglas
Copy link
Owner

dunglas commented Dec 18, 2024

Thank you Vincent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants