docs: explicitly explain how to use without worker mode #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withinboredom
approved these changes
Dec 21, 2024
dunglas
approved these changes
Dec 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to improve documentation on how FrankenPHP operates without using worker mode, clarifying the internals based on my take-aways from the discussion #1241.
Feel free to provide feedback or correct me if I'm wrong.
I don't know how you handle translations for documentation changes, thus I only changed the English version.
Furthermore, especially after reading my own documentation, I believe there should be a configurable connection limit to avoid overloading the queue with too many requests, as well as a wait timeout, after which the request should return a 503 status code. Whether this should be implemented in Caddy or FrankenPHP is up for discussion which should take place in a new issue.